Merge lp://staging/~gunchleoc/ubuntu-keyboard/gd-keyboard into lp://staging/ubuntu-keyboard

Proposed by GunChleoc
Status: Merged
Merged at revision: 370
Proposed branch: lp://staging/~gunchleoc/ubuntu-keyboard/gd-keyboard
Merge into: lp://staging/ubuntu-keyboard
Diff against target: 13984 lines (+13902/-0)
13 files modified
debian/control (+9/-0)
debian/ubuntu-keyboard-scottish-gaelic.install (+1/-0)
plugins/gd/gd.pro (+9/-0)
plugins/gd/qml/Keyboard_gd.qml (+92/-0)
plugins/gd/qml/Keyboard_gd_email.qml (+93/-0)
plugins/gd/qml/Keyboard_gd_url.qml (+92/-0)
plugins/gd/qml/Keyboard_gd_url_search.qml (+93/-0)
plugins/gd/qml/qml.pro (+20/-0)
plugins/gd/src/gaelicplugin.h (+27/-0)
plugins/gd/src/gaelicplugin.json (+7/-0)
plugins/gd/src/src.pro (+48/-0)
plugins/gd/src/teacsa.txt (+13410/-0)
plugins/plugins.pro (+1/-0)
To merge this branch: bzr merge lp://staging/~gunchleoc/ubuntu-keyboard/gd-keyboard
Reviewer Review Type Date Requested Status
GunChleoc (community) Needs Resubmitting
Michael Sheldon (community) Needs Fixing
Review via email: mp+243121@code.staging.launchpad.net

Commit message

New keyboard for Scottish Gaelic (gd).

Description of the change

New keyboard for Scottish Gaelic (gd).

The database only contains 1-grams (see discussion in the bug), but I think it's better to have a keyboard with 1-grams only rather than no keyboard at all.

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Sorry for the delay in reviewing this, there's currently at least one issue that needs to be fixed before this can be resolved fully, at the moment the branch is lacking any packaging for the new layout.

To fix this simply edit the debian/control file and add an entry for this layout similar to the existing ones, e.g.

Package: ubuntu-keyboard-scottish-gaelic
Architecture: any
Depends: ubuntu-keyboard (= ${binary:Version}),
         myspell-gd
         ${misc:Depends},
         ${shlibs:Depends},
Description: Ubuntu on-screen keyboard data files - Scottish Gaelic
 Data files for the Ubuntu virtual keyboard - Scottish Gaelic

And create a file called "debian/ubuntu-keyboard-scottish-gaelic.install" containing the line:

"usr/share/maliit/plugins/com/ubuntu/lib/gd/"

This tells the packaging scripts which files should be included in that package.

Thanks!

review: Needs Fixing
221. By GunChleoc

Added packaging information.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Done. Thanks for the review.

review: Needs Resubmitting
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Hi,

 These changes are now included in the layout-improvements branch alongside a number of other new layouts, however before we can merge it into trunk could you please sign the CLA? http://www.ubuntu.com/legal/contributors

Thanks!
 Mike.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Done :)

I used my e-mail address as Launchpad ID, I hope that is correct.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Great, thanks! I think using the email address should be okay, I'll get back to you if there are any issues.

Revision history for this message
GunChleoc (gunchleoc) wrote :

K thanks :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches