Midori Web Browser

Merge lp://staging/~gue5t/midori/urlunescaping-2 into lp://staging/midori

  1. urlunescaping-2
  2. Merge into trunk
Proposed by gue5t gue5t
Status: Merged
Approved by: Cris Dywan
Approved revision: 6910
Merged at revision: 6926
Proposed branch: lp://staging/~gue5t/midori/urlunescaping-2
Merge into: lp://staging/midori
Diff against target: 89 lines (+47/-13)
2 files modified
katze/midori-uri.vala (+32/-13)
tests/magic-uri.c (+15/-0)
To merge this branch: bzr merge lp://staging/~gue5t/midori/urlunescaping-2
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+253992@code.staging.launchpad.net

Commit message

Reimplement Midori.URI.unescape and add various tests

Description of the change

This changes the URI unescaping logic to fully match what is intended and makes all uri tests pass.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

I feel manual string allocation and manipulation is not going to be easy to maintain. Are there other options to solving this? Maybe using a regular expression?

review: Needs Information
Revision history for this message
Cris Dywan (kalikiana) wrote :

Possible alternative approach as per some discussion in IRC:
1. erase %0 2. Soup.URI.decode 3. re-insert " "

lp://staging/~gue5t/midori/urlunescaping-2 updated
6910. By gue5t <email address hidden>

Simplify and safen Midori.URI.unescape, add a couple more tests

Revision history for this message
Cris Dywan (kalikiana) wrote :

I like it, much more robust and easier to read. Thanks a lot!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: