charm-haproxy

Merge lp://staging/~gtrkiller/charm-haproxy/autocert_bug_fix into lp://staging/charm-haproxy

  1. autocert_bug_fix
  2. Merge into trunk
Proposed by Franco Luciano Forneron Buschiazzo
Status: Merged
Approved by: Tom Haddon
Approved revision: 159
Merged at revision: 157
Proposed branch: lp://staging/~gtrkiller/charm-haproxy/autocert_bug_fix
Merge into: lp://staging/charm-haproxy
Diff against target: 74 lines (+23/-3)
1 file modified
hooks/hooks.py (+23/-3)
To merge this branch: bzr merge lp://staging/~gtrkiller/charm-haproxy/autocert_bug_fix
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+447213@code.staging.launchpad.net

Commit message

bugfix #2027680

Description of the change

With this fix, the charm will now be aware if the cert files are missing and block the charm/restart haproxy accordingly.

To post a comment you must log in.
Revision history for this message
Tom Haddon (mthaddon) wrote :

Some comments inline

lp://staging/~gtrkiller/charm-haproxy/autocert_bug_fix updated
158. By Franco Luciano Forneron Buschiazzo

addressing comments

Revision history for this message
Tom Haddon (mthaddon) wrote :

Some comments inline. I think https://paste.ubuntu.com/p/YhywzTkF7D/ applied to this MP would address the comments, but please test to confirm it works as expected.

lp://staging/~gtrkiller/charm-haproxy/autocert_bug_fix updated
159. By Franco Luciano Forneron Buschiazzo

addressing comments

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, thx

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 157

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches