Merge lp://staging/~gtg-contributors/gtg/bug495246 into lp://staging/~gtg/gtg/old-trunk

Hi Joao,

Nobody reviews your code so far, I'll do it now :-) It looks great and also works great for adding new tags. There are just one problem which should be fixed:

Removing tags does not work well, mostly the task has more than one instance of that tag. You probably use iterators not in the way as it was meant: (I've got this error)

/home/iyo/downloads/bug495246/GTG/gtk/editor/taskview.py:743: GtkWarning: Invalid text buffer iterator: either the iterator is uninitialized, or the characters/pixbufs/widgets in the buffer have been modified since the iterator was created.
You must use marks, character numbers, or line numbers to preserve a position across buffer modifications.
You can apply tags and insert marks without invalidating your iterators,
but any mutation that affects 'indexable' buffer contents (contents that can be referred to by character offset)
will invalidate all outstanding iterators
  if start.get_offset() <= offset2 <= end.get_offset():

Changed the owner to gtg-contributors, fell free to change it. I did it some time ago and had some problems that are a connected to the way the editor works. Editor has some issues detecting tags in the text, Just try to write a log task with the same tag over-repeated and it only detects some instances of the tag.

With the revision of the editor, as stated by lionel, its a great time to look at it again

I played with the algorithm for removing today and updated it. Now it works in two steps:

1) remove highlighted tag
2) remove other occurrences of the tag as well, although they are not highlighted (yet)

Small testing:

I have a task with lot of '@money' tag: http://is.gd/VqlNkR

And I want to remove that tag and properly I get this window: http://is.gd/7hiTd2

Please, test it and see how it will work for you.

By the way: shouldn't be all occurrences of a tag highlighted?

Sorry izidor, only saw this now.

Cumprimentos

João Ascenso

2011/11/6 Izidor Matušov <email address hidden>

> I played with the algorithm for removing today and updated it. Now it
> works in two steps:
>
> 1) remove highlighted tag
> 2) remove other occurrences of the tag as well, although they are not
> highlighted (yet)
>
> Small testing:
>
> I have a task with lot of '@money' tag: http://is.gd/VqlNkR
>
> And I want to remove that tag and properly I get this window:
> http://is.gd/7hiTd2
>
> Please, test it and see how it will work for you.
>

i'll try to check it tommorow, im busy has hell because im at the last days
of a project

>
> By the way: shouldn't be all occurrences of a tag highlighted?
>

there are a few issues with the task editor, when i was adding that feature
there was someone helping me (cant remember who, sorry) he told me that the
editor had that issues and suggested in a near future to be re-visioned and
optimized. It has some issues and sometimes only tags the last occurrence
of a tag. I believe it has to do with the way it iterates thought the text
and colors it. It may be a nice thing for me to focus on the hack metting

> --
> https://code.launchpad.net/~gtg-contributors/gtg/bug495246/+merge/56881<https://code.launchpad.net/%7Egtg-contributors/gtg/bug495246/+merge/56881>
> You proposed lp:~gtg-contributors/gtg/bug495246 for merging.
>

There wasn't activity for almost a year, closing this merge request as REJECTED. If you want to finish your patch, feel free to reopen it.