Terminator

Merge lp://staging/~grizzly-smit/terminator/grizzlysmitsbranch into lp://staging/terminator/trunk

grizzlysmitsbranch
Merge into trunk

Proposed by Grizzly(Francis Smit) on 2011-11-19

Status:	Merged
Merged at revision:	1434
Proposed branch:	lp://staging/~grizzly-smit/terminator/grizzlysmitsbranch
Merge into:	lp://staging/terminator/trunk
Diff against target:	287 lines (+109/-30) 4 files modified terminatorlib/config.py (+1/-0) terminatorlib/notebook.py (+1/-1) terminatorlib/preferences.glade (+91/-29) terminatorlib/prefseditor.py (+16/-0)
To merge this branch:	bzr merge lp://staging/~grizzly-smit/terminator/grizzlysmitsbranch
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Terminator		2011-11-19	Pending
Review via email: mp+82770@code.staging.launchpad.net

Description of the change

I have added a property homogeneous_tabbar to do this I aded line 89 to config.py:
'homogeneous_tabbar' : True,
inside the DEFAULT config structure and changed line 48 of notebook.py to:
self.set_property('homogeneous', self.config['homogeneous_tabbar'])
thus if you can set the homogeneous param from the config file now we just need to expose this and the scroll_tabbar property in the properties and the user will have control over the tab behaviour.

lp://staging/~grizzly-smit/terminator/grizzlysmitsbranch updated on 2011-11-20

1274. By Grizzly(Francis Smit) on 2011-11-20: have added configuration check boxex for scroll_tabbar and homogeneous_tabbar to the preferences dialog box, I'have tested it and it all works

Revision history for this message

Grizzly(Francis Smit) (grizzly-smit) wrote on 2011-11-20:

branch revison 1274 is now ready to be merged instead it has the properties dialog up dated to handle the scroll_tabbar property and my new homogeneous_tabbar property, I hope I am going about this in the right way, please tell me if I am stepping on any toes. I'm just scratching my itche, I love terminator and want these features plus, I want to give back

Revision history for this message

Stephen Boddy (stephen-j-boddy) wrote on 2013-07-16:

Hi Grizzly. I took a look and have an observation. I could very quickly make a mess of the 3 tabs by renaming one tab with a very short name (middle), and another with a very long name (right-most). It is possible for the small one to disappear entirely, and the long one to cause visual garbage. I think scroll_tabbar should be enforced when homogenous_tabbar is turned off.

Revision history for this message

Stephen Boddy (stephen-j-boddy) wrote on 2013-07-17:

Another observation: When I use the scroll_tabbar buttons [<] ----- [>] to move left and right, the focus is not changed to any of the terminals on the current tab. Instead it ends up on the tab label. This ties in a little bit with LP#315956 where switching tabs (clicking directly) always changes focus to the upper left terminal.