Merge lp://staging/~grabli66-r/pantheon-files/inline-progress into lp://staging/~elementary-apps/pantheon-files/trunk

There is at least one missing file - src/ProgressRenderCell.vala. Please add to bzr.

Note that this branch may be delayed for merging by Loki feature freeze.

Thanks for your contribution!

Hi. I think i forgot remove that file from CMakeLists
I'll fix it

2016-05-25 12:25 GMT+03:00 Jeremy Wootten <email address hidden>:

> There is at least one missing file - src/ProgressRenderCell.vala. Please
> add to bzr.
>
> Note that this branch may be delayed for merging by Loki feature freeze.
>
> Thanks for your contribution!
> --
>
> https://code.launchpad.net/~grabli66-r/pantheon-files/inline-progress/+merge/295618
> You are the owner of lp:~grabli66-r/pantheon-files/inline-progress.
>

Update the branch to the latest trunk.

Updated to current trunk

The branch compiles and runs but no inline progress bar appears now.

Further to last comment - the progress bar does not appear when copying to an frp server. It appears when copying to a usb stick.

A. Pasting large files into local directory from another partition
   - Progress bars show nicely but the progress is not shown in blue (but white on grey). The inline progress bar should be themed the same as the other progress bars in Files. Needs fixing.

B. Pasting onto a remote folder (smb, ftp, afp)
 - No inline progress - file does not appear until transfer complete. However, the progress window shows the correct state of the transfer. This might be tricky to fix and could be left for another branch.

C. Pasting onto USB stick
 - The file appears immediately and the Inline progress bar appears briefly and rapidly proceeds to 100% although the file has not been completely transferred to the stick. However, the progress window displays until the transfer is complete (although the progress appears stuck at about 90%). Needs fixing.

However, the branch does provide the basic infrastructure for an inline progressbar - thanks.

I checked that this branch is does not conflict with the current trunk (r2374)

As you can see, need to fix many issues in "Files" to implement
inline-progress.
Sorry, but i don't want see the code of "Files" anymore. It's real mess of
C and Vala code.
Fix that code is a real pain.
I don't want bounty anymore.
You can use branch "inline-progress" as you wish.
Good luck.

2016-11-08 21:41 GMT+03:00 Jeremy Wootten <email address hidden>:

> Review: Needs Fixing appearance
>
> A. Pasting large files into local directory from another partition
> - Progress bars show nicely but the progress is not shown in blue (but
> white on grey). The inline progress bar should be themed the same as the
> other progress bars in Files. Needs fixing.
>
> B. Pasting onto a remote folder (smb, ftp, afp)
> - No inline progress - file does not appear until transfer complete.
> However, the progress window shows the correct state of the transfer. This
> might be tricky to fix and could be left for another branch.
>
> C. Pasting onto USB stick
> - The file appears immediately and the Inline progress bar appears
> briefly and rapidly proceeds to 100% although the file has not been
> completely transferred to the stick. However, the progress window displays
> until the transfer is complete (although the progress appears stuck at
> about 90%). Needs fixing.
>
> However, the branch does provide the basic infrastructure for an inline
> progressbar - thanks.
>
> I checked that this branch is does not conflict with the current trunk
> (r2374)
> --
> https://code.launchpad.net/~grabli66-r/pantheon-files/
> inline-progress/+merge/295618
> You are the owner of lp:~grabli66-r/pantheon-files/inline-progress.
>

I understand that Files code is a PITA to work with. I'll discuss with the bounty backers what they are prepared to accept. It may be that just fixing the theming will be enough as your branch does work for local transfers.

On further investigation the colour of the inline progress bar is due to the focus being stolen from the view by the progress window. If you click on the view then the bar appears blue as required. It is likely that the progress window will be replaced in future by a header bar widget anyway.

Ignore the last comment - it is only true if you replace the custom progress bar with a Gtk.CellRendererProgress.