Noise

Merge lp://staging/~gotwig/noise/translations-gen-fix into lp://staging/~elementary-apps/noise/trunk

translations-gen-fix
Merge into trunk

Proposed by Eduard Gotwig on 2012-08-03

Status:

Merged

Merged at revision:

928

Proposed branch:

lp://staging/~gotwig/noise/translations-gen-fix

Merge into:

lp://staging/~elementary-apps/noise/trunk

Diff against target:

2956 lines (+1248/-1232)

2 files modified

po/noise.pot (+1244/-1228)
src/Widgets/SideTreeView.vala (+4/-4)

To merge this branch:

bzr merge lp://staging/~gotwig/noise/translations-gen-fix

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Victor Martinez (community)		2012-08-03	Approve on 2012-08-04
Review via email: mp+118111@code.staging.launchpad.net

Description of the change

Add all strings that were untranslateable in the past;

This is likely not going to fix the issue that strings that are translateable don't get used, like days, hours, minutes, playlist strings, see bug report.

Revision history for this message

Cody Garver (codygarver) wrote on 2012-08-03:

Shouldn't there be a + in the middle of

p.name = Time.local(time_t()).format(_("Play Queue (%Y-%b-%e %l:%M %p)"));

AND

p.name = Time.local(time_t()).format(_("Play History (%Y-%b-%e %l:%M %p)"));

Otherwise, won't translators be exposed the the date variables?

Revision history for this message

Eduard Gotwig (gotwig) wrote on 2012-08-03:

You mean, that translators can adjust these date variables?

I made it becouse of that, this way.

The time format of the language should be used.

Revision history for this message

Victor Martinez (victored) wrote on 2012-08-04:

Nice work Eduard. There's a typo in diff line 2944 ("Unkown"), but I will fix it before merging since your code doesn't introduce the issue; in fact I'm only mentioning that here to avoid forgetting about it. In regard to what Cody suggested, it's a common practice to let translators change time-format strings.

review: Approve