Merge lp://staging/~gosteven/gtg/fix-816356 into lp://staging/~gtg/gtg/old-trunk
Proposed by
Steven You
| Status: | Rejected |
|---|---|
| Rejected by: | Izidor Matušov |
| Proposed branch: | lp://staging/~gosteven/gtg/fix-816356 |
| Merge into: | lp://staging/~gtg/gtg/old-trunk |
| Diff against target: |
37 lines (+14/-2) 2 files modified
GTG/core/task.py (+12/-0) GTG/gtk/browser/treeview_factory.py (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~gosteven/gtg/fix-816356 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Izidor Matušov | Disapprove | ||
| Luca Invernizzi | Pending | ||
|
Review via email:
|
|||
Description of the change
Fix bug #816356, when sorting the tasks by due date in tasksbrowser, it should compare the due date of the closest child tasks.
To post a comment you must log in.
Unmerged revisions
- 1151. By Steven You
-
Fix bug#816356, when sorting by due-date in taskbrowser, use the closest date of all children. Added a function in task.py: get_due_
date_of_ self_and_ all_subtasks( )
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for a patch. However, your solution doesn't work for this scenario:
a (due next week)
b (due next month)
- c (due tomorrow)
After applying your patch I would expect to have [when sorting by due date, close dates first]
b (due next month)
-c (due tomorrow)
a (due next week)
(b's due date should be replaced by c's tomorrow)