lp://staging/~gophers/goose/unstable-001

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://staging/~gophers/goose/trunk

The Go Language Gophers: Pending requested 2012-12-17

Diff: 374 lines (+52/-43) (has conflicts)

25 files modified

client/client.go (+3/-3)
client/client_test.go (+1/-1)
client/live_test.go (+2/-2)
client/local_test.go (+3/-3)
glance/glance.go (+2/-2)
glance/glance_test.go (+3/-3)
http/client.go (+1/-1)
identity/identity_test.go (+1/-1)
identity/legacy_test.go (+2/-2)
identity/userpass.go (+1/-1)
identity/userpass_test.go (+2/-2)
nova/nova.go (+2/-2)
nova/nova_test.go (+3/-3)
swift/live_test.go (+4/-4)
swift/local_test.go (+4/-4)
swift/swift.go (+2/-2)
swift/swift_test.go (+1/-1)
testservices/identityservice/legacy_test.go (+1/-1)
testservices/identityservice/service_test.go (+1/-1)
testservices/identityservice/userpass_test.go (+1/-1)
testservices/main.go (+1/-1)
testservices/novaservice/service.go (+1/-1)
testservices/novaservice/service_http_test.go (+4/-0)
testservices/novaservice/service_test.go (+5/-0)
testservices/swiftservice/service_http_test.go (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

39. By John A Meinel on 2012-12-13

Rename all the imports to the 'current' branch number.

38. By Dimiter Naydenov on 2012-12-10

Removed the interface and renamed get methods.

This is a follow up to https://codereview.appspot.com/6877054/

As advised, removed the NovaService interface and turned it into an implementation.
Also renamed all getXYZ*() methods to XYZ*() (without get).
Renamed NovaService and NovaServiceSuite to Nova and NovaSuite, respectively.

R=
CC=
https://codereview.appspot.com/6910055

37. By Dimiter Naydenov on 2012-12-10

First part of the nova service double.

As discussed, I'm starting to propose bits of the nova service double in chunks, as I go.
The direct API and its tests are ready. Added a comprehensive comment about RuleInfo struct,
to describe better the types of security group rules.

R=wallyworld, jameinel, rog, dfc
CC=
https://codereview.appspot.com/6877054

36. By Ian Booth on 2012-12-05

Add filtering to ListServers APIs

The results of the nova APIs ListServers and ListServerDetails can now be filtered by status, name etc.

R=jameinel
CC=
https://codereview.appspot.com/6875052

35. By Ian Booth on 2012-12-05

Return slices not pointers

A previous change made all APIs return pointers but this is not necessary when the return type is a slice.
This branch fixes that.

R=dfc, jameinel
CC=
https://codereview.appspot.com/6867052

34. By Ian Booth on 2012-12-05

Fix nova RunServer to return details

The RunServer API was not returning the details of the server just started. This branch fixes that.
It also updates the nova tests to no longer rely on a specific server instance to be running. Instead, the
test suite uses RunServer to create an instance for the tests, and deletes the instance afterwards. This plus a couple
of other tweaks make all but 3 of the nova tests pass. 2 of the remaining 3 are the well known floating IP failures,
and the other is a security tets failure. These can be addressed in another branch.

The work in this branch is needed by the OpenStack provider in juju-core.

R=gz, jameinel
CC=
https://codereview.appspot.com/6872050

33. By Ian Booth on 2012-12-02

Fix some error handling changes

Some changes to error handling were introduced to try and properly handle the case where failed JSON resulted in an err being returned as expected. But the data structures were left possible partially populated.
The previous branch returned nil for this situation but non pointers cannot be set to nil.
This branch use pointers for return data types of nova and glance apis so that nil can be returned if there is an error.

R=
CC=
https://codereview.appspot.com/6869044

32. By John A Meinel on 2012-12-01

testservices/swiftservice: tweak the test infrastructure

We had a function where all tests called the same function, and then asserted
similar results. Instead of having that in the callers, move it into
the called function.

R=dimitern,dave.cheney

31. By Martin Packman on 2012-11-30

Partial revert of r30 to fix testsuite while error handling is debated

30. By Ian Booth on 2012-11-30

Add CompleteCredentialsFromEnv tests, cleanup

CompleteCredentialsFromEnv did not have any test coverage so add some tests.
Also clean up how errors are handled in the various service clients based on advice from a code review.

R=dimitern
CC=
https://codereview.appspot.com/6842121