python-jujuclient

Merge lp://staging/~gnuoy/python-jujuclient/ipv6 into lp://staging/python-jujuclient

  1. ipv6
  2. Merge into trunk
Proposed by Liam Young
Status: Merged
Merged at revision: 56
Proposed branch: lp://staging/~gnuoy/python-jujuclient/ipv6
Merge into: lp://staging/python-jujuclient
Diff against target: 64 lines (+33/-1)
2 files modified
jujuclient.py (+11/-1)
test_jujuclient.py (+22/-0)
To merge this branch: bzr merge lp://staging/~gnuoy/python-jujuclient/ipv6
Reviewer Review Type Date Requested Status
Kapil Thangavelu Approve
Martin Packman (community) Approve
Review via email: mp+258770@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Needs unit test. I'd add a new port-splitting function used here that can be validated with some ipv4 and ipv6 inputs.

review: Needs Fixing
lp://staging/~gnuoy/python-jujuclient/ipv6 updated
57. By Liam Young

Add unit tests and move host port splitting into its own function

Revision history for this message
Martin Packman (gz) wrote :

Looks good. Python style nits inline.

review: Approve
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm, with martin's style nits addressed.

review: Approve
lp://staging/~gnuoy/python-jujuclient/ipv6 updated
58. By Liam Young

Tipdyup after mp feedback

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: