Merge lp://staging/~gnuoy/openstack-mojo-specs/juju-when-are-you-done into lp://staging/openstack-mojo-specs

Proposed by Liam Young
Status: Needs review
Proposed branch: lp://staging/~gnuoy/openstack-mojo-specs/juju-when-are-you-done
Merge into: lp://staging/openstack-mojo-specs
Diff against target: 122 lines (+48/-11)
2 files modified
helper/tests/check_juju.py (+1/-2)
helper/utils/mojo_utils.py (+47/-9)
To merge this branch: bzr merge lp://staging/~gnuoy/openstack-mojo-specs/juju-when-are-you-done
Reviewer Review Type Date Requested Status
OpenStack Charm Testing Maintainers Pending
Review via email: mp+274390@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

How mojo detects when juju has finished can now be influenced by two environment variables.

1) JUJU_RUN_TIMEOUT When the system being deployed on is busy sometimes the default 5mins is not enough so this can be set to a higher value to make juju run wait longer for the queued run action to complete
2) USE_WORKLOAD_STATUS By default this is true and will use the charms workload status to decide when the charms are finished. Setting this to 'false' will cause mojo to flip back to the old behaviour of relying on juju run.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11894 mojo-openstack-specs for gnuoy mp274390
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/11894/

Unmerged revisions

229. By Liam Young

Allow JUJU_RUN_TIMEOUT to be set to specify juju run timeout

228. By Liam Young

Use workload status to check deploy has finished unless disabled by USE_WORKLOAD_STATUS

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches