Merge lp://staging/~gnuoy/openstack-mojo-specs/designate-queens into lp://staging/~ost-maintainers/openstack-mojo-specs/openstack-mojo-specs-1802

Proposed by Liam Young
Status: Merged
Merged at revision: 360
Proposed branch: lp://staging/~gnuoy/openstack-mojo-specs/designate-queens
Merge into: lp://staging/~ost-maintainers/openstack-mojo-specs/openstack-mojo-specs-1802
Diff against target: 492 lines (+251/-65)
5 files modified
helper/bundles/designate-next-ha.yaml (+14/-2)
helper/setup/designate_setup.py (+50/-30)
helper/tests/expand_and_shrink_bind.py (+34/-15)
helper/tests/validate_designate.py (+4/-1)
helper/utils/mojo_os_utils.py (+149/-17)
To merge this branch: bzr merge lp://staging/~gnuoy/openstack-mojo-specs/designate-queens
Reviewer Review Type Date Requested Status
Ryan Beisner Approve
Chris MacNaughton (community) Needs Fixing
Review via email: mp+340833@code.staging.launchpad.net
To post a comment you must log in.
354. By Liam Young <email address hidden>

Fix typo

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Looks ok except for:

#neutron-api cs:~openstack-charmers-next/neutron-api
neutron-api cs:~gnuoy/neutron-api-4;channel=unpublished

review: Needs Fixing
355. By Liam Young <email address hidden>

Fix collect

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Have xenial-mitaka running on OSCI @ http://10.245.162.49:8080/job/mojo_runner/5136/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

See key error paste inline. Thank you.

review: Needs Fixing
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches