Openstack Mojo Testing

Merge lp://staging/~gnuoy/openstack-mojo-specs/add-designate-ha-tests into lp://staging/openstack-mojo-specs

add-designate-ha-tests
Merge into mojo-openstack-specs

Proposed by Liam Young on 2018-01-29

Status:	Merged
Merged at revision:	327
Proposed branch:	lp://staging/~gnuoy/openstack-mojo-specs/add-designate-ha-tests
Merge into:	lp://staging/openstack-mojo-specs
Diff against target:	747 lines (+578/-8) 9 files modified helper/bundles/designate-next-ha.yaml (+406/-0) helper/collect/collect-next-reactive-xenial (+1/-0) helper/setup/preflight.py (+1/-0) helper/tests/expand_and_shrink_bind.py (+59/-0) helper/utils/mojo_os_utils.py (+80/-1) specs/full_stack/next_deploy_designate/mitaka/manifest (+8/-2) specs/full_stack/next_deploy_designate/newton/manifest (+8/-2) specs/full_stack/next_deploy_designate/ocata/manifest (+7/-1) specs/full_stack/next_deploy_designate/pike/manifest (+8/-2)
To merge this branch:	bzr merge lp://staging/~gnuoy/openstack-mojo-specs/add-designate-ha-tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
David Ames (community)		2018-01-29	Approve on 2018-02-05
Review via email: mp+336756@code.staging.launchpad.net

Revision history for this message

David Ames (thedac) wrote on 2018-01-30:

A couple of stray debug prints.

But also we seem to be using the first version of the next_deploy_designate spec while changing the bundle from reactive-next.yaml to designate-next.yaml.

Do the original tests all pass?
Should we get rid of one or the other of the bundles?
The original intent of reactive-next.yaml was to have a place for all of the new charms.
Should this be the HA version of that?

review: Needs Fixing

Revision history for this message

Liam Young (gnuoy) wrote on 2018-02-02:

I'll remove the stray debug prints.

The reactive-next.yaml and new designate-next.yaml differ only in the way designate is deployed. In designate-next.yaml designate and designate-bind are deployed in an HA configuration so that the bind resilience tests can be run. I decided to extend the existing next_deploy_designate spec because it seemed pointless to have a designate non-ha and designate ha spec.

I think ultimately you are correct and designate-next.yaml is the beginnings of an HA version of reactive-next.yaml but I think a full HA version of reactive-next.yaml is beyond the scope of this change.

Finally, the original tests that are part of next_deploy_designate do pass. The nova sink tests currently fails due to a designate regression in master.

lp://staging/~gnuoy/openstack-mojo-specs/add-designate-ha-tests updated on 2018-02-02