OpenStack Charm Testing

Merge lp://staging/~gnuoy/openstack-charm-testing/ksv3-new into lp://staging/openstack-charm-testing

ksv3-new
Merge into trunk

Proposed by Liam Young on 2016-03-31

Status:	Merged
Merged at revision:	193
Proposed branch:	lp://staging/~gnuoy/openstack-charm-testing/ksv3-new
Merge into:	lp://staging/openstack-charm-testing
Diff against target:	852 lines (+717/-19) 12 files modified .bzrignore (+1/-0) bin/neutron-ext-net-ksv3 (+159/-0) bin/neutron-tenant-net-ksv3 (+158/-0) bin/post-deploy-config (+8/-4) bin/quantum-ext-net (+7/-11) bin/quantum-tenant-net (+2/-3) bundles/keystone-v3/next.yaml (+246/-0) configure (+1/-1) novarcv3_domain (+14/-0) novarcv3_project (+15/-0) profiles/keystonev3 (+101/-0) unset_all (+5/-0)
To merge this branch:	bzr merge lp://staging/~gnuoy/openstack-charm-testing/ksv3-new
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
David Ames (community)		2016-03-31	Approve on 2016-04-01
Review via email: mp+290598@code.staging.launchpad.net

Revision history for this message

David Ames (thedac) wrote on 2016-03-31:

Not sure if we have a style standard for this repo as there is no Makefile but flake8 has a few issues you might want to fix:

flake8 bin/neutron*
bin/neutron-ext-net:75:1: W293 blank line contains whitespace
bin/neutron-ext-net:76:5: E303 too many blank lines (2)
bin/neutron-ext-net:80:5: E129 visually indented line with same indent as next logical line
bin/neutron-ext-net:131:21: E122 continuation line missing indentation or outdented
bin/neutron-ext-net:132:21: E122 continuation line missing indentation or outdented
bin/neutron-ext-net:147:80: E501 line too long (87 > 79 characters)
bin/neutron-ext-net-ksv3:77:5: E129 visually indented line with same indent as next logical line
bin/neutron-ext-net-ksv3:128:21: E122 continuation line missing indentation or outdented
bin/neutron-ext-net-ksv3:129:21: E122 continuation line missing indentation or outdented
bin/neutron-ext-net-ksv3:144:80: E501 line too long (88 > 79 characters)
bin/neutron-tenant-net:79:5: E129 visually indented line with same indent as next logical line
bin/neutron-tenant-net:100:70: W291 trailing whitespace
bin/neutron-tenant-net-ksv3:86:5: E129 visually indented line with same indent as next logical line
bin/neutron-tenant-net-ksv3:107:70: W291 trailing whitespace