Snap Layer

Merge ~gnuoy/layer-snap:bug/1934163 into layer-snap:master

  1. Git
  2. lp:~gnuoy/layer-snap
  3. bug/1934163
  4. Merge into master
Proposed by Liam Young
Status: Merged
Merged at revision: c6596fd57129581b338da6fb59b6e4395d1e85b7
Proposed branch: ~gnuoy/layer-snap:bug/1934163
Merge into: layer-snap:master
Diff against target: 49 lines (+19/-16)
1 file modified
lib/charms/layer/snap.py (+19/-16)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Cory Johns (community) Approve
Aurelien Lourot (community) Approve
Review via email: mp+405019@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :

LGTM, thanks!

review: Approve
Revision history for this message
Cory Johns (johnsca) wrote :

LGTM as well. The loop pattern was added in 6.0.0 [1] but the decorator pattern has always been supported.

[1]: https://github.com/jd/tenacity/commit/3646aea1602a4854779eaae66a613e3262c7b5d0

review: Approve
Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, have merged

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches