Merge lp://staging/~gnuoy/charms/precise/nova-compute/control-mtu into lp://staging/~charmers/charms/precise/nova-compute/trunk

Proposed by Liam Young
Status: Rejected
Rejected by: James Page
Proposed branch: lp://staging/~gnuoy/charms/precise/nova-compute/control-mtu
Merge into: lp://staging/~charmers/charms/precise/nova-compute/trunk
Diff against target: 540 lines (+150/-33)
6 files modified
config.yaml (+5/-0)
hooks/charmhelpers/core/hookenv.py (+78/-23)
hooks/charmhelpers/core/host.py (+49/-9)
hooks/nova_compute_hooks.py (+3/-0)
hooks/nova_compute_utils.py (+14/-0)
revision (+1/-1)
To merge this branch: bzr merge lp://staging/~gnuoy/charms/precise/nova-compute/control-mtu
Reviewer Review Type Date Requested Status
James Page Disapprove
Review via email: mp+195231@code.staging.launchpad.net

Description of the change

Add ability to control mtu on nics and sync core charmhelpers (to pull in nic mtu functions).

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Discussed with liam and we agreed that the correct way todo this was during network interface configuration during install via MAAS.

review: Disapprove

Unmerged revisions

50. By Liam Young

Add ability to control mtu on nics and sync charmhelpers (to pull in nic mtu functions). I've only pulled in the charmhelpers core update

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: