Charm Helpers

Merge lp://staging/~gnuoy/charm-helpers/1496746 into lp://staging/charm-helpers

  1. 1496746
  2. Merge into devel
Proposed by Liam Young
Status: Merged
Merged at revision: 450
Proposed branch: lp://staging/~gnuoy/charm-helpers/1496746
Merge into: lp://staging/charm-helpers
Diff against target: 158 lines (+79/-7)
4 files modified
charmhelpers/core/hugepage.py (+8/-1)
charmhelpers/core/strutils.py (+30/-0)
tests/core/test_hugepage.py (+26/-6)
tests/core/test_strutils.py (+15/-0)
To merge this branch: bzr merge lp://staging/~gnuoy/charm-helpers/1496746
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+271443@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Looking at https://www.kernel.org/doc/Documentation/vm/hugetlbpage.txt the pagesize option that is used to mount the hugepages should be set in bytes not human readable equivalent and that makes working out shmmax much easier too.

lp://staging/~gnuoy/charm-helpers/1496746 updated
451. By Liam Young

Add function to convert human readable representation of quantity of bytes (eg 1G) to int

Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches