Merge lp://staging/~gmb/launchpad/liar-liar-pants-on-fiar-bug-193870 into lp://staging/launchpad
Proposed by
Graham Binns
| Status: | Merged |
|---|---|
| Approved by: | Gavin Panella |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12036 |
| Proposed branch: | lp://staging/~gmb/launchpad/liar-liar-pants-on-fiar-bug-193870 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
299 lines (+103/-35) 6 files modified
lib/lp/bugs/stories/structural-subscriptions/xx-bug-subscriptions.txt (+28/-28) lib/lp/registry/browser/configure.zcml (+2/-0) lib/lp/registry/browser/structuralsubscription.py (+20/-0) lib/lp/registry/browser/tests/test_structuralsubscription.py (+48/-2) lib/lp/registry/templates/structural-subscription-target-portlet-subscribers.pt (+3/-3) lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~gmb/launchpad/liar-liar-pants-on-fiar-bug-193870 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[r=allenap]
Description of the change
This branch clears up some confusing UI in the structural subscribers
portlet. It's a fairly simple change, which swaps out the existing
TAL-based logic for a simple LaunchpadView which generates the necessary
labels.
I've added a unit test to cover the new labels and have updated
pagetests where appropriate.
To post a comment you must log in.
Revision history for this message
| Gavin Panella (allenap) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
