Launchpad itself

database/schema/trusted.sql (+2/-1)
lib/canonical/launchpad/scripts/garbo.py (+22/-31)
lib/lp/bugs/doc/bug-heat.txt (+114/-50)
lib/lp/bugs/model/bug.py (+17/-14)
lib/lp/bugs/tests/test_bugheat.py (+0/-102)

To merge this branch:

bzr merge lp://staging/~gmb/launchpad/hook-up-stored-proc-boom-bug-585803

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Curtis Hovey (community)	rc		Approve on 2010-05-27
Abel Deuring (community)	code	2010-05-27	Approve on 2010-05-27
Review via email: mp+26191@code.staging.launchpad.net

Commit message

Bug heat is now updated directly rather than relying on CalculateBugHeatJob creation.

Description of the change

This branch converts all current sites where CalculateBugHeatJobs are created to use IBug.updateHeat() or to call the calculate_bug_heat() stored procedure directly.

I've removed all CalculateBugHeatJob creation callsites (except in tests, which I'll remove in a subsequent branch along with all the CalculateBugHeatJob infrastructure) and I've updated the BugHeatUpdater garbo job to call the calculate_bug_heat() stored procedure directly rather than looping over out-of-date bugs.

I've also removed the tests that covered the callsites that I've removed.

Revision history for this message

Abel Deuring (adeuring) wrote on 2010-05-27:

Hi Graham,

we discussed that it would be better to update the heat values in chunks, with initial chunk size of 1000. I like your implementation as in http://pastebin.ubuntu.com/440470/

thanks for finally fixing the heat updater!

review: Approve (code)

Revision history for this message

Curtis Hovey (sinzui) wrote on 2010-05-27:

This is good to land and you have my RC to ensure this landed even if ec2 runs slowly.

review: Approve (rc)