Merge lp://staging/~gmb/charms/oneiric/buildbot-master/tests-fixes into lp://staging/~yellow/charms/oneiric/buildbot-master/trunk
Proposed by
Graham Binns
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden |
| Approved revision: | 17 |
| Merged at revision: | 16 |
| Proposed branch: | lp://staging/~gmb/charms/oneiric/buildbot-master/tests-fixes |
| Merge into: | lp://staging/~yellow/charms/oneiric/buildbot-master/trunk |
| Diff against target: |
47 lines (+20/-3) 1 file modified
hooks/helpers.py (+20/-3) |
| To merge this branch: | bzr merge lp://staging/~gmb/charms/oneiric/buildbot-master/tests-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Changes from gmb and frankban 2012-02-08:
=======
- Added some tweaks to helpers.py to make testing a bit easier.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Francesco and Graham,
These changes look good.
I think if you use base64.b64encode() you don't get the extra '\n' and may not need to strip it.
s/proably/probably