Merge lp://staging/~glower/ols-jenkaas/serial-vault into lp://staging/ols-jenkaas

Proposed by Igor Komlew
Status: Rejected
Rejected by: Daniel Manrique
Proposed branch: lp://staging/~glower/ols-jenkaas/serial-vault
Merge into: lp://staging/ols-jenkaas
Diff against target: 15 lines (+3/-0)
1 file modified
jobs/serial-vault.yaml (+3/-0)
To merge this branch: bzr merge lp://staging/~glower/ols-jenkaas/serial-vault
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+392280@code.staging.launchpad.net

Commit message

Added parameterized-snap-store-staging-deploy jenkins job to serial-vault

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

2 configs are missing: staging-rollout-command and deploy-group

review: Needs Fixing
768. By Igor Komlew

Added missing config

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Looks good, will hold landing this until the new user is setup in wendigo with the proper ssh keys, etc

review: Approve
Revision history for this message
Igor Komlew (glower) wrote :

OK, make sense

Revision history for this message
Daniel Manrique (roadmr) wrote :

Rejecting to clear the queue (it's been almost 2 years), feel free to clone and repropose this branch if still needed.

Unmerged revisions

768. By Igor Komlew

Added missing config

767. By Igor Komlew

Added parameterized-staging-deploy-on-charm-changes job to serial-vault

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches