Merge lp://staging/~gl-az/percona-server/BT-27444-bug1083700 into lp://staging/percona-server/5.5
Proposed by
George Ormond Lorch III
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 367 |
Proposed branch: | lp://staging/~gl-az/percona-server/BT-27444-bug1083700 |
Merge into: | lp://staging/percona-server/5.5 |
Diff against target: |
16 lines (+5/-1) 1 file modified
Percona-Server/storage/innobase/fsp/fsp0fsp.c (+5/-1) |
To merge this branch: | bzr merge lp://staging/~gl-az/percona-server/BT-27444-bug1083700 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Laurynas Biveinis (community) | Needs Fixing | ||
Alexey Kopytov (community) | Approve | ||
Review via email: mp+136473@code.staging.launchpad.net |
Description of the change
Fix for lp 1083700 and 1079596:
An unsigned math error in fsp_reserve_
27444
Jenkins run for same code but different branch name before bug was split off:
http://
To post a comment you must log in.
This fix does not take into account the existing special small tablespace (size < FSP_EXTENT_SIZE / 2, i.e. 32 pages) handling in fsp_reserve_ free_extents( ). Such tablespaces have free_limit > size by design. Thus a combination of this and of http:// bugs.mysql. com/bug. php?id= 68970 aka bug 1169494 (where tablespaces between 32 and 64 pages are treated as big tablespaces even though for them free_limit > size holds, resulting in unexpected or extremely counter-intuitive if intended unsigned math) means that small tablespaces balloon (a testcase innodb_ wl6347_ comp_indx_ stat from 5.6):
@@ -987,7 +987,7 @@ name='test' name='test' name='test'
AND table_name='tab5' AND database_
AND index_name like 'idx%' ;
compress_stat 1
-The size of the tab5.ibd file: 159744
+The size of the tab5.ibd file: 2097152
# fetch the compressed page and check the stats
===============
Fetch Records
@@ -1013,7 +1013,7 @@
AND table_name='tab5' AND database_
AND index_name like 'idx%' ;
compress_stat 1
-The size of the tab5.ibd file: 159744
+The size of the tab5.ibd file: 2097152
# fetch the compressed same page once again and check the stats
# the stat figures should be same as above query
===============
@@ -1040,7 +1040,7 @@
AND table_name='tab5' AND database_
AND index_name like 'idx%' ;
compress_stat 1
-The size of the tab5.ibd file: 159744
+The size of the tab5.ibd file: 2097152
#cleanup
DROP TABLE IF EXISTS tab5;
#reset the stat table before starting next testcase
mysqltest: Result content mismatch
Thus, we will have to fix bug 1169494 now.