LightDM GTK Greeter

Merge lp://staging/~gilir/lightdm-gtk-greeter/fix-ubuntu into lp://staging/~agateau/lightdm-gtk-greeter/ubuntu

fix-ubuntu
Merge into ubuntu

Proposed by Julien Lavergne on 2012-01-20

Status:	Merged
Merged at revision:	5
Proposed branch:	lp://staging/~gilir/lightdm-gtk-greeter/fix-ubuntu
Merge into:	lp://staging/~agateau/lightdm-gtk-greeter/ubuntu
Diff against target:	18 lines (+7/-1) 1 file modified debian/control (+7/-1)
To merge this branch:	bzr merge lp://staging/~gilir/lightdm-gtk-greeter/fix-ubuntu
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Aurélien Gâteau		2012-01-20	Approve on 2012-01-23
Review via email: mp+89480@code.staging.launchpad.net

Description of the change

Adding missing build-depends.
Testing packages pushed to https://launchpad.net/~lubuntu-dev/+archive/staging to fix Lubuntu precise login

Revision history for this message

Aurélien Gâteau (agateau) wrote on 2012-01-23:

Thanks for this branch Julien!

I am wondering if we could reduce the build-dep a bit though: I am not sure why we need gtk-doc-tools. I also think the gobject-introspection dependency can be removed with a small source change: from what I understand configure.ac looks for it but it is never used. Will look into this later, I am merging your branch in first.

review: Approve

Revision history for this message

Julien Lavergne (gilir) wrote on 2012-01-23:

I added gtk-doc-tools because otherwise configure.ac complains about GNOME_COMPILE_WARNINGS(maximum), but I didn't look at it very closely. Also, GOBJECT_INTROSPECTION_CHECK(0.9.5) and the build-depend could probably be removed too, there is no g-i support in this greeter.