Merge lp://staging/~gholt/swift/atriskparts into lp://staging/~hudson-openstack/swift/trunk

Proposed by gholt
Status: Merged
Approved by: Jay Payne
Approved revision: 295
Merged at revision: 298
Proposed branch: lp://staging/~gholt/swift/atriskparts
Merge into: lp://staging/~hudson-openstack/swift/trunk
Diff against target: 81 lines (+45/-1)
2 files modified
bin/swift-ring-builder (+36/-1)
swift/common/ring/builder.py (+9/-0)
To merge this branch: bzr merge lp://staging/~gholt/swift/atriskparts
Reviewer Review Type Date Requested Status
Jay Payne (community) Approve
David Goetz (community) Approve
Review via email: mp+60716@code.staging.launchpad.net

Commit message

swift-ring-builder: Added list_parts command which shows common partitions for a given list of devices.

Description of the change

This is part 1) of the linked blueprint.

Added to swift-ring-builder:

swift-ring-builder <builder_file> list_parts <search-value> [<search-value>] ..
    Lists the common partitions for the matching devices, in order of partition
    most matching to least matching. If there are a lot of devices to match
    against, this command could take a while to run.

To post a comment you must log in.
290. By gholt

PEP8 fix

291. By gholt

Merged from trunk

292. By gholt

Merged from trunk

293. By gholt

Merged from trunk

294. By gholt

Merged from trunk

Revision history for this message
David Goetz (david-goetz) wrote :

Change the help in the command to maybe something like:

Returns a 2 column list of all partitions that match any of the search values given in the first column and the number of search matches in the second. The partitions are ordered from most number of matches to least. If there are a lot of devices to match against, this command could take a while to run.

295. By gholt

swift-ring-builder: Updated help for list_parts

Revision history for this message
David Goetz (david-goetz) wrote :

Looks good

review: Approve
Revision history for this message
Jay Payne (letterj) wrote :

Works great

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.