Slingshot

Merge lp://staging/~gero-bare/slingshot/add_search_for_keyword into lp://staging/~elementary-pantheon/slingshot/trunk

  1. add_search_for_keyword
  2. Merge into trunk
Proposed by Gero.Bare
Status: Rejected
Rejected by: Adam Bieńkowski
Proposed branch: lp://staging/~gero-bare/slingshot/add_search_for_keyword
Merge into: lp://staging/~elementary-pantheon/slingshot/trunk
Diff against target: 129 lines (+48/-2)
4 files modified
CMakeLists.txt (+12/-2)
lib/synapse-core/CMakeLists.txt (+3/-0)
lib/synapse-core/desktop-file-service.vala (+8/-0)
lib/synapse-plugins/desktop-file-plugin.vala (+25/-0)
To merge this branch: bzr merge lp://staging/~gero-bare/slingshot/add_search_for_keyword
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+296097@code.staging.launchpad.net

Description of the change

Add support for search for keywords.

Due the fact that gio-unix had the definition broken for AppInfo.get_keyword this was blocking me, but apparently this will be fixed soon.

In case of having vala > 0.32.0 or vala > 0.30.1 this should work out of the box, if not we can rely on unity.

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Marking as rejected as the bug is already fixed.

Unmerged revisions

658. By Gero.Bare

Add search for keyword using Appinfo.

It's necesary have vala > 0.32.0, or vala > 0.30.1 to compile using AppInfo.get_keywords
for previus version you can use unity.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches