Scratch

Merge lp://staging/~gero-bare/scratch/fix-1637173 into lp://staging/~elementary-apps/scratch/scratch

  1. fix-1637173
  2. Merge into scratch
Proposed by Gero.Bare
Status: Needs review
Proposed branch: lp://staging/~gero-bare/scratch/fix-1637173
Merge into: lp://staging/~elementary-apps/scratch/scratch
Diff against target: 288 lines (+31/-31)
19 files modified
CMakeLists.txt (+4/-4)
plugins/filemanager/Settings.vala (+1/-1)
plugins/folder-manager/Settings.vala (+1/-1)
plugins/outline/CtagsSymbolResolver.vala (+1/-1)
plugins/outline/OutlinePlugin.vala (+1/-1)
plugins/outline/ValaProcessing/SymbolOutline.vala (+1/-1)
plugins/outline/icons/outline.gresource.xml (+1/-1)
plugins/source-tree/Settings.vala (+1/-1)
plugins/spell/Settings.vala (+1/-1)
plugins/terminal/Settings.vala (+1/-1)
plugins/terminal/terminal.vala (+2/-2)
schemas/CMakeLists.txt (+5/-5)
schemas/io.elementary.scratch.gschema.xml (+3/-3)
schemas/io.elementary.scratch.plugins.file-manager.gschema.xml (+1/-1)
schemas/io.elementary.scratch.plugins.folder-manager.gschema.xml (+1/-1)
schemas/io.elementary.scratch.plugins.spell.gschema.xml (+1/-1)
schemas/io.elementary.scratch.plugins.terminal.gschema.xml (+1/-1)
src/Scratch.vala (+1/-1)
src/Services/Settings.vala (+3/-3)
To merge this branch: bzr merge lp://staging/~gero-bare/scratch/fix-1637173
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Approve
Review via email: mp+309516@code.staging.launchpad.net

Description of the change

Move schemes from /org/patheon to /io/elementary and all the references related.

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

Looks good to me.

review: Approve
Reply
Revision history for this message
MarkoD (markodolar) wrote :

After update, wouldn't this reset all user settings to default? I didn't notice any code that moves old settings to new scheme. Is it possible to do it or is not needed at all?

Reply
Revision history for this message
Zisu Andrei (matzipan) wrote :

It would reset everything to default. I don't think there's much worth. Scratch is pretty easy to set up.

Reply
Revision history for this message
MarkoD (markodolar) wrote :

I agree that settings are not that critical, what about any unsaved documents? They also don't open. (they still exist in hidden unsaved folder so user would have to know about it to recover them)

Reply
Revision history for this message
Zisu Andrei (matzipan) wrote :

Fair point. Gero, thoughts?

review: Needs Information
Reply
Revision history for this message
Gero.Bare (gero-bare) wrote :

> Fair point. Gero, thoughts?

I didn't thought in the documents and that's a really fair point.

This need to be discussed with the UX team, meanwhile we can't risk to lose documents.

So we need to put this on hold. Also I really don't know how to tackle this, maybe just move the files? A post inst script?

Reply
Revision history for this message
Zisu Andrei (matzipan) wrote :

Come to think of it, this issue will only hit daily users, which know how to fix this issue. The users which switch from Loki to Juno will do a fresh install anyway.

review: Approve
Reply

Unmerged revisions

1771. By Gero.Bare

Move schemas from /org/pantheon to /io/elementary

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches