Midori Web Browser

Merge lp://staging/~gero-bare/midori/midori-bug-1281211 into lp://staging/midori

  1. midori-bug-1281211
  2. Merge into trunk
Proposed by Gero.Bare
Status: Work in progress
Proposed branch: lp://staging/~gero-bare/midori/midori-bug-1281211
Merge into: lp://staging/midori
Diff against target: 38 lines (+12/-2)
1 file modified
midori/midori-view.c (+12/-2)
To merge this branch: bzr merge lp://staging/~gero-bare/midori/midori-bug-1281211
Reviewer Review Type Date Requested Status
gue5t gue5t Disapprove
Review via email: mp+243350@code.staging.launchpad.net

Description of the change

Please check if this is a sane implementation.

It seems correct to me, but I could be wrong.

Not much to add. I simply added a check to verify if the user make a click with the middle button over a part of a document (document < image), if it is then ignore that.

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

I don't think this is the right way to fix this problem. It doesn't address other parts of the same bug, such as double-clicking the scrollbar also opening a new tab. I'll dig up the precise commit that caused these problems when I get a chance.

review: Disapprove
Reply
Revision history for this message
Gero.Bare (gero-bare) wrote :

@gue5t
Please could you update the bug description with all the relevant info.
That would be awesome, in case that anyone want to tackle this.

Reply

Unmerged revisions

6837. By Gero.Bare

Prevent to open new tab when a click over an image is issued.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: