Storm

Merge lp://staging/~gerdusvanzyl/storm/firebird into lp://staging/storm

Proposed by Gerdus van Zyl on 2010-06-26

Status:	Needs review
Proposed branch:	lp://staging/~gerdusvanzyl/storm/firebird
Merge into:	lp://staging/storm
Diff against target:	587 lines (+427/-27) 4 files modified storm/databases/firebird.py (+229/-0) tests/databases/base.py (+25/-25) tests/databases/firebird.py (+171/-0) tests/databases/proxy.py (+2/-2)
To merge this branch:	bzr merge lp://staging/~gerdusvanzyl/storm/firebird
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Storm Developers	2010-08-02	Pending
Storm Developers	2010-06-26	Pending
Review via email: mp+28559@code.staging.launchpad.net

Basic Firebird database support.

Passes all tests except "Connection.rollback() swallows disconnect errors" which I have so far been unable to fix.

example connection string env variable for tests: STORM_FIREBIRD_URI=firebird://sysdba:masterke@localhost:3050/stormtest.fdb

Revision history for this message

Gustavo Niemeyer (niemeyer) wrote on 2010-08-10:

Hi Gerdus,

Thanks for pushing this forward into a request!

Sorry if this has been asked already, but if not, can you please sign the contributor agreement at:

Revision history for this message

Gerdus van Zyl (gerdusvanzyl) wrote on 2010-08-10:

No problem, I have just sent the email as per the instructions.

On Tue, Aug 10, 2010 at 7:23 PM, Gustavo Niemeyer <email address hidden> wrote:
> Hi Gerdus,
>
> Thanks for pushing this forward into a request!
>
> Sorry if this has been asked already, but if not, can you please sign the contributor agreement at:
>
> http://www.canonical.com/contributors
> --
> https://code.launchpad.net/~gerdusvanzyl/storm/firebird/+merge/28559
> You are the owner of lp:~gerdusvanzyl/storm/firebird.
>

--
Gerdus van Zyl

368. By Gerdus van Zyl on 2010-06-16: merge from trunk
367. By Gerdus van Zyl on 2010-06-16: cleanup unused comments
366. By Gerdus van Zyl on 2010-06-16: fixed proxy to work on windows
replaced os.read(self.request.fileno() .. with self.request.recv
365. By Gerdus van Zyl on 2010-06-16: -
364. By Gerdus van Zyl on 2010-06-16: disconnect cleanup, push to vpc
363. By Gerdus van Zyl on 2010-06-16: is_disconnection_error
362. By Gerdus van Zyl on 2010-06-16: test cases for returning and select limit
361. By Gerdus van Zyl on 2010-06-13: start of disconnect test, fix base database test to not use "select 1"
360. By Gerdus van Zyl on 2010-06-13: cleanup and override non implementable tests
359. By Gerdus van Zyl on 2010-06-06: code to pass test test_execute_expression and test_execute_expression_empty_params