unity-mir

Merge lp://staging/~gerboland/unity-mir/unfocusOnGreeter into lp://staging/unity-mir

  1. unfocusOnGreeter
  2. Merge into trunk
Proposed by Gerry Boland
Status: Needs review
Proposed branch: lp://staging/~gerboland/unity-mir/unfocusOnGreeter
Merge into: lp://staging/unity-mir
Diff against target: 48 lines (+11/-2)
2 files modified
src/modules/Unity/Application/application_manager.cpp (+8/-0)
tests/application_manager_test.cpp (+3/-2)
To merge this branch: bzr merge lp://staging/~gerboland/unity-mir/unfocusOnGreeter
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
kevin gunn (community) Needs Fixing
Michael Zanetti (community) Approve
Review via email: mp+227940@code.staging.launchpad.net

Commit message

AppMan: emit unfocus dbus event on suspend, and focus on resume

Description of the change

AppMan: emit unfocus dbus event on suspend, and focus on resume

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:246
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/403/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-i386-ci/67

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/403/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Michael Zanetti (mzanetti) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?

Yip yip

 * Did CI run pass? If not, please explain why.

it did!

review: Approve
Reply
Revision history for this message
kevin gunn (kgunn72) wrote :

so, its my understanding this was proposed to fix https://bugs.launchpad.net/unity-mir/+bug/1346367
unfortunately, I tested this MP against image #148

per the bug instructions, running
gdbus call -e -d com.ubuntu.Postal -o /com/ubuntu/Postal/_ -m com.ubuntu.Postal.Post _ubuntu-system-settings '"null"'

on the device shell, would present a notification "update available" (or some such)
OK on top of dash
NOT OK on top of greeter
NOT OK with screen blanked

review: Needs Fixing
Reply
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Hmm, odd. Would be interesting to know what this Postal service does. Locking the screen _does_ report "no app focused" now with the greeter locked as requested in the bug report.

Reply
Revision history for this message
Gerry Boland (gerboland) wrote :

Reading the Postal code, it actually queries GetWindowStack to check if the appId is focused or not. It's not listening for the focus change signals at all. Updating my code to match

Reply
lp://staging/~gerboland/unity-mir/unfocusOnGreeter updated
247. By Gerry Boland

Set focusedApplication to be unfocused/focused on suspend/resume

248. By Gerry Boland

Add test

249. By Gerry Boland

Fat finger fix

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:247
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/404/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-amd64-ci/68
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/68/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-i386-ci/68

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/404/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:249
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/405/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-amd64-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-armhf-ci/69/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-utopic-i386-ci/69

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/405/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

249. By Gerry Boland

Fat finger fix

248. By Gerry Boland

Add test

247. By Gerry Boland

Set focusedApplication to be unfocused/focused on suspend/resume

246. By Gerry Boland

AppMan: emit unfocus dbus event on suspend, and focus on resume

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches