Merge lp://staging/~gerboland/unity-2d/hud-misc-fixes into lp://staging/unity-2d
Proposed by
Gerry Boland
| Status: | Merged |
|---|---|
| Approved by: | Paweł Stołowski |
| Approved revision: | 1012 |
| Merged at revision: | 1019 |
| Proposed branch: | lp://staging/~gerboland/unity-2d/hud-misc-fixes |
| Merge into: | lp://staging/unity-2d |
| Diff against target: |
90 lines (+25/-11) 3 files modified
libunity-2d-private/src/hud.cpp (+19/-7) libunity-2d-private/src/hud.h (+2/-1) shell/hud/Hud.qml (+4/-3) |
| To merge this branch: | bzr merge lp://staging/~gerboland/unity-2d/hud-misc-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paweł Stołowski (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[hud] Improve monitoring of HUD service connection: reset data properly and disconnect only when connected
Description of the change
[hud] Improve monitoring of HUD service connection: reset data properly and disconnect only when connected
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Can you initialize m_hudQueryOpen in ctor just to be on the safe side, in case anyone adds any logic based on it in the future?
Also, I'd use at least UQ_WARNING to signal connection error, rather than UQ_DEBUG.