platform-api

Merge lp://staging/~gerboland/platform-api/add-magnetic-gyro-sensors into lp://staging/platform-api/15.04

  1. add-magnetic-gyro-sensors
  2. Merge into 15.04
Proposed by Gerry Boland
Status: Rejected
Rejected by: Gerry Boland
Proposed branch: lp://staging/~gerboland/platform-api/add-magnetic-gyro-sensors
Merge into: lp://staging/platform-api/15.04
Diff against target: 1856 lines (+1530/-11)
18 files modified
android/default/default_ubuntu_application_sensor.cpp (+423/-0)
android/hybris/test_sensors_c_api.cpp (+40/-0)
android/include/private/application/sensors/events.h (+70/-10)
android/include/private/application/sensors/sensor_reading.h (+1/-0)
debian/changelog (+6/-0)
debian/control (+1/-1)
debian/libubuntu-application-api3.symbols (+13/-0)
examples/test_sensors_api.cpp (+40/-0)
include/ubuntu/application/sensors/CMakeLists.txt (+2/-0)
include/ubuntu/application/sensors/event/CMakeLists.txt (+2/-0)
include/ubuntu/application/sensors/event/gyroscope.h (+86/-0)
include/ubuntu/application/sensors/event/magnetic.h (+81/-0)
include/ubuntu/application/sensors/gyroscope.h (+144/-0)
include/ubuntu/application/sensors/magnetic.h (+142/-0)
src/ubuntu/application/desktop/ubuntu_application_sensors_desktop.cpp (+194/-0)
src/ubuntu/application/testbackend/ubuntu_application_sensors.cpp (+213/-0)
src/ubuntu/application/touch/hybris/ubuntu_application_sensors_hybris.cpp (+36/-0)
src/ubuntu/application/ubuntu_application_api.cpp (+36/-0)
To merge this branch: bzr merge lp://staging/~gerboland/platform-api/add-magnetic-gyro-sensors
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Thomas Voß Pending
Review via email: mp+275000@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-09-08.

Commit message

Add APIs for Gyroscopic and Magnetic Field sensors

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:318
http://jenkins.qa.ubuntu.com/job/platform-api-ci/436/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/49/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/49/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/49/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/436/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:318
http://jenkins.qa.ubuntu.com/job/platform-api-ci/437/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/50/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/50/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/50/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/437/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Thomas Voß (thomas-voss) wrote : Posted in a previous version of this proposal

A few minor niggles inline.

review: Needs Fixing
Reply
Revision history for this message
Gerry Boland (gerboland) wrote : Posted in a previous version of this proposal

I added const to all Sensor Event accessors

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:319
http://jenkins.qa.ubuntu.com/job/platform-api-ci/443/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-amd64-ci/56/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-armhf-ci/56/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-vivid-i386-ci/56/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/443/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Thomas Voß (thomas-voss) wrote : Posted in a previous version of this proposal

LGTM.

review: Approve
Reply
lp://staging/~gerboland/platform-api/add-magnetic-gyro-sensors updated
320. By Gerry Boland

Merge trunk

Revision history for this message
Gerry Boland (gerboland) wrote : Posted in a previous version of this proposal

Unsuperceding, as dual-landing working again, and superceding MP has now incorrect target

Reply
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote : Posted in a previous version of this proposal

It seems this is pending in https://requests.ci-train.ubuntu.com/#/ticket/1099

Reply

Unmerged revisions

322. By Gerry Boland

Fix debian symbols file for landing

321. By Gerry Boland

Merge trunk

320. By Gerry Boland

Merge trunk

319. By Gerry Boland

Make Sensor event accessors const

318. By Gerry Boland

Fix sensor-type errors, fixes up magnetic field sensor

317. By Gerry Boland

Fix up build on android

316. By Gerry Boland

Add Magnetic field sensor API

315. By Gerry Boland

Add new symbols to symbols file

314. By Gerry Boland

Fix build error

313. By Gerry Boland

Add Gyroscope sensor API

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches