Merge ~georgiag/qa-regression-testing:dbus-failed-ok into qa-regression-testing:master

Proposed by Georgia Garcia
Status: Needs review
Proposed branch: ~georgiag/qa-regression-testing:dbus-failed-ok
Merge into: qa-regression-testing:master
Diff against target: 15 lines (+4/-0)
1 file modified
scripts/test-apparmor.py (+4/-0)
Reviewer Review Type Date Requested Status
Alex Murray Needs Information
Review via email: mp+453056@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

Is it correct to assume that one of these two needs to be available? If so, if neither is installed will th e test appear to succeed?

review: Needs Information
Revision history for this message
Georgia Garcia (georgiag) wrote :

> Is it correct to assume that one of these two needs to be available?

I'm not sure, but I would assume so. The apparmor package does not depend on dbus, so I don't know if this is the place to make sure any form of a dbus daemon is installed. But that depends on the "architecture" of the qa-regression-test suite in general - for example, if test-apparmor.py fails, does it mean that there is an issue with apparmor specifically or with the system as a whole?

> If so, if neither is installed will th e test appear to succeed?

Correct, the tests would succeed with the message
"Starting DBus Daemon failed. Skipping tests..." and "Starting DBus Broker failed. Skipping tests..."

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches