Merge lp://staging/~gaurav-gangalwar/swift/trunk into lp://staging/~hudson-openstack/swift/trunk

Proposed by Gaurav Gangalwar
Status: Merged
Approved by: Chuck Thier
Approved revision: 335
Merged at revision: 334
Proposed branch: lp://staging/~gaurav-gangalwar/swift/trunk
Merge into: lp://staging/~hudson-openstack/swift/trunk
Diff against target: 21 lines (+2/-2)
1 file modified
swift/common/middleware/swift3.py (+2/-2)
To merge this branch: bzr merge lp://staging/~gaurav-gangalwar/swift/trunk
Reviewer Review Type Date Requested Status
Chuck Thier (community) Approve
FUJITA Tomonori (community) Approve
Review via email: mp+69420@code.staging.launchpad.net

Description of the change

Fix for Bug #812092
https://bugs.launchpad.net/swift/+bug/812092

Setting content-type=application/xml for "GET services/bucket" S3 requests.

To post a comment you must log in.
Revision history for this message
FUJITA Tomonori (fujita-tomonori-deactivatedaccount) wrote :

Looks good. Thanks!

review: Approve
Revision history for this message
Chuck Thier (cthier) wrote :

Thank you for this contribution. For us to accept it, can you sign the CLA and add your name to the contributors list as described here: http://wiki.openstack.org/HowToContribute

And then add yourself to the AUTHORS list for this merge.

Once that is done we can get it in.

Thanks!

--
Chuck

334. By <email address hidden>

Updated Authors list for this merge.

Revision history for this message
Gaurav Gangalwar (gaurav-gangalwar) wrote :

Done.

Thanks,
Gaurav

On Thu, Jul 28, 2011 at 8:36 PM, Chuck Thier <email address hidden> wrote:

> Thank you for this contribution. For us to accept it, can you sign the CLA
> and add your name to the contributors list as described here:
> http://wiki.openstack.org/HowToContribute
>
> And then add yourself to the AUTHORS list for this merge.
>
> Once that is done we can get it in.
>
> Thanks!
>
> --
> Chuck
> --
> https://code.launchpad.net/~gaurav-gangalwar/swift/trunk/+merge/69420<https://code.launchpad.net/%7Egaurav-gangalwar/swift/trunk/+merge/69420>
> You are the owner of lp:~gaurav-gangalwar/swift/trunk.
>

Revision history for this message
Chuck Thier (cthier) wrote :

Hi Gaurav, I still don't see your entry on the contributors list (http://wiki.openstack.org/Contributors). If you have signed the CLA, please add your info there, thanks! And yeah, sorry this is so complicated just to get a little change in :/

335. By <email address hidden>

Revert AUTHORS.

Revision history for this message
Gaurav Gangalwar (gaurav-gangalwar) wrote :

Finally got it right, hope its updated in contributors list.
Thanks,
Gaurav

On Fri, Jul 29, 2011 at 8:20 PM, Chuck Thier <email address hidden> wrote:

> Hi Gaurav, I still don't see your entry on the contributors list (
> http://wiki.openstack.org/Contributors). If you have signed the CLA,
> please add your info there, thanks! And yeah, sorry this is so complicated
> just to get a little change in :/
> --
> https://code.launchpad.net/~gaurav-gangalwar/swift/trunk/+merge/69420<https://code.launchpad.net/%7Egaurav-gangalwar/swift/trunk/+merge/69420>
> You are the owner of lp:~gaurav-gangalwar/swift/trunk.
>

Revision history for this message
Chuck Thier (cthier) wrote :

Awesome, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.