Unity

Merge lp://staging/~gaul/unity/on_entry_added_leak into lp://staging/unity

  1. on_entry_added_leak
  2. Merge into trunk
Proposed by Andrew Gaul
Status: Merged
Approved by: Stephen M. Webb
Approved revision: no longer in the source branch.
Merged at revision: 3440
Proposed branch: lp://staging/~gaul/unity/on_entry_added_leak
Merge into: lp://staging/unity
Diff against target: 19 lines (+9/-0)
1 file modified
services/panel-service.c (+9/-0)
To merge this branch: bzr merge lp://staging/~gaul/unity/on_entry_added_leak
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Christopher Townsend (community) Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+176102@code.staging.launchpad.net

Commit message

PanelService: Disconnect signals connected in panel-service.c:on_entry_added

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks, that's correct... I put it on another place, but not there.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ah, one more thing... It seems you didn't sign the Contributor Agreement, could you please that?

More infos at http://www.canonical.com/contributors

Thank you.

Revision history for this message
Christopher Townsend (townsend) wrote :

Yes, looks good to me as well. Thanks for catching this!

I'll globally approve this either after you have signed the Contributor Agreement or if we can get an exception for this merge.

review: Approve
Revision history for this message
Andrew Gaul (gaul) wrote :

I just submitted an individual contributor agreement. Can you also apply this against Unity 5.x (for Ubuntu 12.04)?

Revision history for this message
Stephen M. Webb (bregma) wrote :

A CLA is not required for this change because it's considered trivial.

"We do not require a contributor agreement for trivial changes. One practical test for a trivial change is that it would be feasible to describe the change in English over the phone and apply it correctly."

Revision history for this message
Andrew Gaul (gaul) wrote :

I received a mail notifying me that Canonical accepted my CLA:

Michelle Surtees-Myers (michelle-canonical) added you as a member of Canonical Contributor Agreement (contributor-agreement-canonical).

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Andrew, that's cool thanks (even if it was probably not needed I hope you'll need that soon for other contributions! :-) ).

To backport this to 12.04 we would need a branch against lp:unity/5.0 could you please provide it? Since precise has glib 2.32, g_signal_handlers_disconnect_by_data should work just fine even there.

Revision history for this message
Andrew Gaul (gaul) wrote :

I requested a merge into 5.x here:

https://code.launchpad.net/~gaul/unity/on_entry_added_leak_5.0/+merge/176754

I botched the first request but this second one should target the correct branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

FYI, I've just proposed a new branch that includes tests for this change: lp:~3v1n0/unity/ups-signal-tests/+merge/176919 ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.