Merge lp://staging/~gaspa/a4/mode_switch into lp://staging/a4
Proposed by
Andrea Gasparini
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 73 | ||||
| Proposed branch: | lp://staging/~gaspa/a4/mode_switch | ||||
| Merge into: | lp://staging/a4 | ||||
| Diff against target: |
18 lines (+5/-0) 1 file modified
a4lib/app.py (+5/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~gaspa/a4/mode_switch | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrea Colangelo | Approve | ||
|
Review via email:
|
|||
Description of the change
saving and setting the "current_region" of a presentation in order to preserve the visualization between mode switches.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks like this code just partially address the issue.
Although region is preserved in the drawing_area, arrows doesn't cycle correctly. For example: if you open a presentation, reach the third region, switch to editor, and hit the 'next' button, A4 will bump to the first region. Saving and restoring self.player.
Anyway, I am pushing the merge proposal with this fix, just to avoid waiting more time to have this branch re-submitted and re-reviewed (many of us are still in vacation, etc.). Since this is a trivial patch, we can easily rollback and/or re-factor the code if needed.
BTW: since current_region is a property, I'm wondering if we shouldn't rather use its getter and setter (and maybe re-factor view_status as a property as well).