A4

Merge lp://staging/~gaspa/a4/a4-transforms into lp://staging/a4

Proposed by Andrea Gasparini
Status: Merged
Merged at revision: 11
Proposed branch: lp://staging/~gaspa/a4/a4-transforms
Merge into: lp://staging/a4
Diff against target: 285 lines (+123/-19)
3 files modified
a4lib/app.py (+44/-5)
a4lib/presentation.py (+44/-12)
ui/window_main.glade (+35/-2)
To merge this branch: bzr merge lp://staging/~gaspa/a4/a4-transforms
Reviewer Review Type Date Requested Status
Andrea Gualano Approve
Review via email: mp+27240@code.staging.launchpad.net

Description of the change

This merge adds these feature:
- a toolbar with two simple Previous/Next buttons. They add just a simple way to navigate through our presentation.
- changed WindowMain.render() function in order to take parameters specifying the right transformation to see a given object.
- Presentation now handle matrix reductions in the right way, and split a given 'whole transformation matrix' to scaling,translating,angle parameters.
All these properties are still inside a dict() because we should study what really the viewer need to know.

To post a comment you must log in.
Revision history for this message
Andrea Gualano (andrea-gualano) wrote :

This is clearly a bug in the PEP8 checker:
- context.translate(-x0, -y0)
- context.translate(-translate[0], -translate[1])
+ context.translate(-x0, - y0)
+ context.translate(-translate[0], - translate[1])

See: http://pypi.python.org/pypi/pep8

Revision history for this message
Andrea Gualano (andrea-gualano) wrote :

It works well and is a big step forward.
Let's merge it.

review: Approve
Revision history for this message
Andrea Gualano (andrea-gualano) wrote :

Also, I have got a small graphical glitch: the two toolbar buttons are very small, with no text.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches