A4

Merge lp://staging/~gaspa/a4/a4-code-testing-review into lp://staging/a4

  1. a4-code-testing-review
  2. Merge into trunk
Proposed by Andrea Gasparini
Status: Merged
Merged at revision: 43
Proposed branch: lp://staging/~gaspa/a4/a4-code-testing-review
Merge into: lp://staging/a4
Prerequisite: lp://staging/~daniele-de-luca/a4/A4-code-testing
Diff against target: 150 lines (+37/-46)
2 files modified
a4lib/player.py (+33/-44)
a4lib/region.py (+4/-2)
To merge this branch: bzr merge lp://staging/~gaspa/a4/a4-code-testing-review
Reviewer Review Type Date Requested Status
Andrea Colangelo Approve
Review via email: mp+29549@code.staging.launchpad.net

Description of the change

a little of refactoring in Daniele's branch, _mouse_step_factor() and all code that should know about mouse position is moved in GtkCairoPlayer().

Did a little of cleanup using pep8 as well.

To post a comment you must log in.
Revision history for this message
Andrea Colangelo (warp10) wrote :

Great work!
Merging now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches