Merge lp://staging/~garyvdm/pyjunitxml/consistant_test_ids into lp://staging/pyjunitxml

Proposed by Gary van der Merwe
Status: Needs review
Proposed branch: lp://staging/~garyvdm/pyjunitxml/consistant_test_ids
Merge into: lp://staging/pyjunitxml
Diff against target: 130 lines (+22/-14)
1 file modified
junitxml/tests/test_junitxml.py (+22/-14)
To merge this branch: bzr merge lp://staging/~garyvdm/pyjunitxml/consistant_test_ids
Reviewer Review Type Date Requested Status
Robert Collins Needs Fixing
Martin Packman Needs Information
Review via email: mp+291497@code.staging.launchpad.net

Description of the change

This fixes Bug #1491635.

I makes the test tests use a implementation of TestCase.id that is consistent across different python versions.

To post a comment you must log in.
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Sorry. I pushed using git-remote-bzr has not maintained commit ids. I will repush using bzr.

28. By Gary van der Merwe

For TestJUnitXmlResult use a TestCase.id implementation that is consistant accross different python versions.

Revision history for this message
Martin Packman (gz) wrote :

See inline comments.

review: Needs Information
Revision history for this message
Robert Collins (lifeless) :
review: Needs Fixing
Revision history for this message
Robert Collins (lifeless) wrote :

ping

Unmerged revisions

28. By Gary van der Merwe

For TestJUnitXmlResult use a TestCase.id implementation that is consistant accross different python versions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches