Merge lp://staging/~gary/lazr.restful/bug871944 into lp://staging/lazr.restful
Proposed by
Gary Poster
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Graham Binns | ||||
| Approved revision: | 199 | ||||
| Merged at revision: | 197 | ||||
| Proposed branch: | lp://staging/~gary/lazr.restful/bug871944 | ||||
| Merge into: | lp://staging/lazr.restful | ||||
| Diff against target: |
158 lines (+62/-10) 5 files modified
src/lazr/restful/NEWS.txt (+6/-0) src/lazr/restful/_resource.py (+14/-7) src/lazr/restful/tests/test_etag.py (+1/-1) src/lazr/restful/tests/test_webservice.py (+40/-1) src/lazr/restful/version.txt (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~gary/lazr.restful/bug871944 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Be more careful in obtaining old and new values when determining cache invalidation.
Description of the change
The related bug describes the problem that this branch solves. The solution I chose is fairly straightforward and involves fairly isolated changes to the codebase: keep the field and original value around in the cache too, so we can get the new value with the expected name, and compare it against the real original value. I added a test which failed before my change, and passed with it.
Launchpad appears to be happy with these changes.
To post a comment you must log in.
Revision history for this message
| Graham Binns (gmb) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
