Launchpad itself

Merge lp://staging/~gary/launchpad/testfix into lp://staging/launchpad

testfix
Merge into devel

Proposed by Gary Poster on 2011-09-02

Status:	Merged
Approved by:	Gary Poster on 2011-09-02
Approved revision:	no longer in the source branch.
Merged at revision:	13853
Proposed branch:	lp://staging/~gary/launchpad/testfix
Merge into:	lp://staging/launchpad
Diff against target:	64 lines (+36/-7) 1 file modified lib/lp/codehosting/tests/test_acceptance.py (+36/-7)
To merge this branch:	bzr merge lp://staging/~gary/launchpad/testfix
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gary Poster (community)			Approve on 2011-09-02
Review via email: mp+73840@code.staging.launchpad.net

Commit message

add diagnostic information for when the lpserve test subprocess starts up incorrectly.

Description of the change

This testfix actually adds diagnostic information, rather than fixing the problem, because we cannot duplicate the problem locally or on buildbot in isolation.

I don't love this approach (with the prints and the string search for "error") but I don't see a compelling alternative either. Suggestions welcome.

When something fails in the server, you get something like this: http://pastebin.ubuntu.com/680631/ .

This is only used in a layer that is only used in the module in which it is defined, as verified by grep and by "./bin/test -vvc --layer=SSHServerLayer --list-tests", and tests pass in that module, so I don't think I'll be making anything worse by landing this.

Revision history for this message

Gary Poster (gary) on 2011-09-02:

review: Approve

Revision history for this message

Robert Collins (lifeless) wrote on 2011-09-09:

If you make ForkingServerForTests a fixtures.Fixture then you *can*
use addDetail - and you *should* do this to avoid stomping on subunit
test output.

Revision history for this message

Gary Poster (gary) wrote on 2011-09-09:

On Sep 9, 2011, at 5:10 PM, Robert Collins wrote:

> make ForkingServerForTests a fixtures.Fixture then you *can*
> use addDetail - and you *should* do this to avoid stomping on subunit
> test output.

OK. I created a card for this (and the sql counter duplication you mentioned elsewhere) for me to look at once I've finished my current task.

Thanks

Gary

Revision history for this message

Robert Collins (lifeless) wrote on 2011-09-10:

On Sat, Sep 10, 2011 at 11:34 AM, Gary Poster <email address hidden> wrote:
>
> On Sep 9, 2011, at 5:10 PM, Robert Collins wrote:
>
>> make ForkingServerForTests a fixtures.Fixture then you *can*
>> use addDetail - and you *should* do this to avoid stomping on subunit
>> test output.
>
> OK. I created a card for this (and the sql counter duplication you mentioned elsewhere) for me to look at once I've finished my current task.

Awesome, thanks. If you run into any tricky bits please let me know.

-Rob