Merge lp://staging/~gary/launchpad/move-bugnotificationlevel-enum into lp://staging/launchpad/db-devel

Proposed by Gary Poster
Status: Merged
Approved by: Leonard Richardson
Approved revision: no longer in the source branch.
Merged at revision: 10165
Proposed branch: lp://staging/~gary/launchpad/move-bugnotificationlevel-enum
Merge into: lp://staging/launchpad/db-devel
Prerequisite: lp://staging/~gary/launchpad/move-events-to-filters
Diff against target: 490 lines (+76/-63)
25 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+1/-1)
lib/canonical/launchpad/mail/helpers.py (+1/-1)
lib/lp/bugs/browser/bugsubscription.py (+1/-1)
lib/lp/bugs/browser/bugsubscriptionfilter.py (+1/-1)
lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+1/-1)
lib/lp/bugs/browser/tests/test_bugsubscriptionfilter.py (+4/-4)
lib/lp/bugs/doc/bug-change.txt (+1/-1)
lib/lp/bugs/doc/bugnotification-sending.txt (+1/-1)
lib/lp/bugs/doc/bugsubscription.txt (+1/-1)
lib/lp/bugs/enum.py (+49/-0)
lib/lp/bugs/interfaces/bugsubscription.py (+1/-1)
lib/lp/bugs/interfaces/bugsubscriptionfilter.py (+1/-1)
lib/lp/bugs/model/bug.py (+1/-1)
lib/lp/bugs/model/bugsubscription.py (+1/-1)
lib/lp/bugs/model/bugsubscriptionfilter.py (+1/-1)
lib/lp/bugs/model/bugtask.py (+2/-2)
lib/lp/bugs/model/tests/test_bug.py (+1/-1)
lib/lp/bugs/model/tests/test_bugsubscriptionfilter.py (+1/-1)
lib/lp/bugs/model/tests/test_bugsubscriptioninfo.py (+1/-1)
lib/lp/bugs/model/tests/test_bugtask.py (+1/-1)
lib/lp/bugs/subscribers/bug.py (+1/-1)
lib/lp/bugs/tests/test_bugchanges.py (+1/-1)
lib/lp/bugs/tests/test_bugsubscription.py (+1/-1)
lib/lp/bugs/tests/test_structuralsubscriptiontarget.py (+1/-1)
lib/lp/registry/enum.py (+0/-36)
To merge this branch: bzr merge lp://staging/~gary/launchpad/move-bugnotificationlevel-enum
Reviewer Review Type Date Requested Status
Leonard Richardson (community) Approve
Review via email: mp+48178@code.staging.launchpad.net

Commit message

[r=leonardr][ui=none][no-qa] move the bugnotificationlevel enum from registry to bugs.

Description of the change

This branch moves the bugnotificationlevel enum from registry to bugs. This is a cleanup, because the bugnotificationlevel has everything to do with bugs, and very little to do with registry.

This branch is intended to be mechanical: simply moving the enum and fixing imports.

Thank you

To post a comment you must log in.
Revision history for this message
Leonard Richardson (leonardr) wrote :

Looks good.

Should the copyright date on lib/lp/bugs/enum.py be 2011? 2010 is probably fine since it's old code.

review: Approve
Revision history for this message
Gary Poster (gary) wrote :

Thank you for the review.

Yes, the reason I kept 2010 was because it was old code. I just updated the date to 2010-2011 since I had touched it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: