Launchpad itself

Merge lp://staging/~gary/launchpad/eggtarget into lp://staging/launchpad

  1. eggtarget
  2. Merge into devel
Proposed by Gary Poster
Status: Merged
Merged at revision: not available
Proposed branch: lp://staging/~gary/launchpad/eggtarget
Merge into: lp://staging/launchpad
Diff against target: 19 lines (+4/-1)
1 file modified
Makefile (+4/-1)
To merge this branch: bzr merge lp://staging/~gary/launchpad/eggtarget
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Francis J. Lacoste (community) Approve
Review via email: mp+15904@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

This branch adds a target for the LOSAs to use to build eggs in such a way that they can be packaged up and copied elsewhere.

It is different from the current approach (``make bin/buildout && bin/buildout``) in two ways.

First, it silences the output of bin/buildout if there are no errors, which is nice, because building the eggs can produce some suspicious-looking output (having to do with Python 2.6 syntax tests, for instance) that shouldn't cause any worries unless buildout bails out.

Second and more importantly, it clears out the *.pyc files in the eggs. On the downside, this means that starting up the webservers will be slightly slower. On the upside, it means that the tracebacks in our OOPSes actually will contain a line of code for each frame run within the code of these eggs. We regard that as very important.

To test, ``make buildonce_eggs``. That will be the replacement line for ``bin/buildout && bin/buildout`` once this lands.

Thanks

Gary

Revision history for this message
Francis J. Lacoste (flacoste) :
review: Approve
Revision history for this message
Tom Haddon (mthaddon) wrote :

Looks good as far as I can see.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2009-12-02 07:00:41 +0000
3+++ Makefile 2009-12-09 22:45:44 +0000
4@@ -137,6 +137,9 @@
5 @echo "Developers: please run utilities/link-external-sourcecode."
6 @exit 1
7
8+buildonce_eggs: $(PY)
9+ find eggs -name '*.pyc' -exec rm {} \;
10+
11 # The download-cache dependency comes *before* eggs so that developers get the
12 # warning before the eggs directory is made. The target for the eggs directory
13 # is only there for deployment convenience.
14@@ -364,4 +367,4 @@
15 check check_merge \
16 schema default launchpad.pot check_merge_ui pull scan sync_branches\
17 reload-apache hosted_branches check_db_merge check_mailman check_config\
18- jsbuild clean_js
19+ jsbuild clean_js buildonce_eggs