Launchpad itself

Merge lp://staging/~gary/launchpad/bug988541 into lp://staging/launchpad

  1. bug988541
  2. Merge into devel
Proposed by Gary Poster
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 15163
Proposed branch: lp://staging/~gary/launchpad/bug988541
Merge into: lp://staging/launchpad
Diff against target: 14 lines (+2/-2)
1 file modified
lib/lp/soyuz/tests/test_packagecloner.py (+2/-2)
To merge this branch: bzr merge lp://staging/~gary/launchpad/bug988541
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+103778@code.staging.launchpad.net

Commit message

Make some tests less likely to fail intermittently because of ordering issues.

Description of the change

This is a simple change to make tests better handle ordering issues, which show up intermittently (see bug 988541). AFAICT the order is not important, so I changed the comparison to sets. Subsequently these tests pass reliably.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Changing to not care about ordering looks reasonable to me, Gary.

As discussed on IRC I think assertContentEqual would do an unordered comparison.

review: Approve (code)
Revision history for this message
Gary Poster (gary) wrote :

Cool, makes sense. Changed. Thank you!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.