Merge lp://staging/~gary/launchpad/bug856048 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Gary Poster |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 14016 |
| Proposed branch: | lp://staging/~gary/launchpad/bug856048 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
392 lines (+74/-102) 6 files modified
lib/canonical/launchpad/webapp/adapter.py (+3/-26) lib/canonical/launchpad/webapp/tests/test_statementtracer.py (+23/-18) lib/lp/bugs/browser/tests/test_expose.py (+7/-7) lib/lp/bugs/model/tests/test_personsubscriptioninfo.py (+10/-8) lib/lp/bugs/tests/test_duplicate_handling.py (+1/-1) lib/lp/testing/__init__.py (+30/-42) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug856048 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | code | Approve | |
| Raphaël Badin (community) | code* | Approve | |
|
Review via email:
|
|||
Commit message
[r=allenap,rvb][bug=856048][no-qa] Merge SQLLogger and StormStatementR
Description of the change
Merge SQLLogger and StormStatementR
Per a comment from Robert, I'm getting rid of my recently introduced SQLLogger by merging it with StormStatementR
The new StormStatementR
* It collects accurate timings and database names.
* It can collect tracebacks never (default), always or conditionally.
* printing it gives you a view of what happened, including any gathered tracebacks, making it useful for interactive data-gathering work.
Lint is happy.
Thank you
Gary
Hi Gary,
This branch looks good ((+74/-102) really good I should say). Thanks for doing this and simplifying our arsenal to analyse sql statements.