Merge lp://staging/~gary/launchpad/bug811447 into lp://staging/launchpad

Proposed by Gary Poster
Status: Merged
Approved by: Gary Poster
Approved revision: no longer in the source branch.
Merged at revision: 13859
Proposed branch: lp://staging/~gary/launchpad/bug811447
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~gary/launchpad/bug838869
Diff against target: 181 lines (+65/-18)
2 files modified
lib/lp/bugs/model/personsubscriptioninfo.py (+15/-14)
lib/lp/bugs/model/tests/test_personsubscriptioninfo.py (+50/-4)
To merge this branch: bzr merge lp://staging/~gary/launchpad/bug811447
Reviewer Review Type Date Requested Status
j.c.sackett (community) Approve
Review via email: mp+73704@code.staging.launchpad.net

Commit message

[r=jcsackett][bug=811447] drastically reduce the number of SQL needed for users who are team administrators and view a bug with many duplicates to which one or more of their teams is subscribed.

Description of the change

This branch fixes bug 811447 by drastically reducing the number of SQL needed for users who are team administrators and view a bug with many duplicates to which one or more of their teams is subscribed. It now takes a single query. This is done by converting the resultset of administrated teams to a list of administrated team ids, and then that list is consulted, rather than the result set.

Lint is happy.

This depends on lp:~gary/launchpad/bug838869 for a tool I used as test fixture.

Thank you.

To post a comment you must log in.
Revision history for this message
j.c.sackett (jcsackett) wrote :

Nice work, Gary.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.