Merge lp://staging/~gary/launchpad/bug792493 into lp://staging/launchpad/db-devel
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 10648 |
| Proposed branch: | lp://staging/~gary/launchpad/bug792493 |
| Merge into: | lp://staging/launchpad/db-devel |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug792493 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=bac][bug=792493,792502] On pillars' +subscriptions page, when you add a subscription for a team it should not offer the "mute" button if there is a preferred email. We update data now so this is done correctly. Also, anonymous users should be challenged to authenticate when they click on a bug's subscribe link; they are now.
Description of the change
This branch fixes the two linked bugs.
For the main (critical) bug, I just added information about whether the team had a preferred email. If a team does, we shouldn't draw the structural subscription mute button (because it won't work, because if it did, it would be a lie). I added tests for the Python side. The JS side doesn't have any tests that are close to this part of the world, so I didn't add any. :-/
I also fixed bug 792502, with the simple change in bugtask_
lint is happy.
Thank you!
This branch looks great Gary and makes a lot of sense. Thanks for the fixes.