Merge lp://staging/~gary/launchpad/bug771232 into lp://staging/launchpad
Proposed by
Gary Poster
| Status: | Merged |
|---|---|
| Approved by: | Gary Poster |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12941 |
| Proposed branch: | lp://staging/~gary/launchpad/bug771232 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
55 lines (+34/-0) 2 files modified
lib/lp/registry/javascript/structural-subscription.js (+7/-0) lib/lp/registry/javascript/tests/test_structural_subscription.js (+27/-0) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug771232 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[r=allenap][bug=771232] In structural subscription overlay, make sure that any old form overlay is destroyed before a new one is created, in order to fix some rendering problems.
Description of the change
This branch fixes the linked bug by making sure that any old form overlay is destroyed before a new one is created. The problem before was that we were never deleting the old overlays, so when we set the edit header the first time, it worked, but subsequently we were changing the header of old, trash form overlays and the new one was displayed with the wrong header.
Thank you
To post a comment you must log in.
Revision history for this message
| Gavin Panella (allenap) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
