Merge lp://staging/~gary/launchpad/bug770387 into lp://staging/launchpad
Proposed by
Gary Poster
| Status: | Merged |
|---|---|
| Approved by: | Benji York |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12935 |
| Proposed branch: | lp://staging/~gary/launchpad/bug770387 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
25 lines (+5/-0) 2 files modified
lib/lp/registry/browser/person.py (+2/-0) lib/lp/registry/stories/person/xx-person-edit.txt (+3/-0) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug770387 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=benji][bug=770387] add a confirmation that we saved your personal details on the +edit page
Description of the change
This is a very simple branch to add a confirmation that we saved your personal details on the +edit page. It is not specific to the bug that this nominally fixes because the entire page had the behavior described for the new field.
I considered constructing a more specific message about what you changed, but it would have made the confirmation message more unwieldy; it doesn't have much precedence in Launchpad, if any, to my knowledge; and the Launchpad form machinery is not currently structured in such a way as to provide information about what was changed.
Lint is happy.
To post a comment you must log in.
Revision history for this message
| Benji York (benji) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
