Launchpad itself

Merge lp://staging/~gary/launchpad/bug770287 into lp://staging/launchpad

  1. bug770287
  2. Merge into devel
Proposed by Gary Poster
Status: Merged
Approved by: Gary Poster
Approved revision: no longer in the source branch.
Merged at revision: 12919
Proposed branch: lp://staging/~gary/launchpad/bug770287
Merge into: lp://staging/launchpad
Diff against target: 126 lines (+33/-17)
2 files modified
lib/lp/bugs/browser/structuralsubscription.py (+9/-10)
lib/lp/registry/browser/tests/test_subscription_links.py (+24/-7)
To merge this branch: bzr merge lp://staging/~gary/launchpad/bug770287
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+58979@code.staging.launchpad.net

Commit message

[r=benji][bug=770287] If there is no bugtracker on a product, do not render links, even if the parent project has a bugtracker

Description of the change

This branch fixes an edge case, as described in https://bugs.edge.launchpad.net/launchpad/+bug/770287 and the first comment.

Using the helper seemed the most elegant approach: the helper's "pillar" was exactly the value we wanted.

lint is happy, after rearranging some comments.

Thank you.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.