Merge lp://staging/~gary/launchpad/bug750561-2 into lp://staging/launchpad/db-devel
| Status: | Merged |
|---|---|
| Approved by: | Gary Poster |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 10421 |
| Proposed branch: | lp://staging/~gary/launchpad/bug750561-2 |
| Merge into: | lp://staging/launchpad/db-devel |
| Prerequisite: | lp://staging/~gary/launchpad/bug750561-2-base-merge |
| Diff against target: |
135 lines (+60/-7) 2 files modified
lib/lp/registry/javascript/structural-subscription.js (+19/-5) lib/lp/registry/javascript/tests/test_structural_subscription.js (+41/-2) |
| To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug750561-2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=benji][bug=750561] add a spinner for when you mute a structural subscription.
Description of the change
This branch adds an activity indicator (spinner) to the team structural subscription per-person "mute" UI. It is a follow-on to https:/
This branch has a dependency on that previous branch. I merged it into db-devel and resolved conflicts in order to give this MP a clean diff.
In the tests, as with the previous branch, I cleaned up and normalized our use of "simulate" as part of the work.
To look at the effects, follow these instructions http://
To QA, make sure you are in a team that has access to the feature-flagged UI (or simply be happy that it is behind feature flags, and move on).
This branch looks good.
Unlike some of the other string constants in this file, I like the use
of descriptive names for the muted and unmuted CSS classes.